Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small error in Documentation #2172

Closed
JarrodM-M opened this issue Apr 1, 2022 · 2 comments
Closed

Small error in Documentation #2172

JarrodM-M opened this issue Apr 1, 2022 · 2 comments
Assignees
@Sandi2212
Labels
documentation to do with docs good first issue Good for newcomers

Comments

@JarrodM-M
Copy link

Found a small error in the Real World Use Cases of the v8 Migration Guide

The example code describing that array's must be explicit is missing the .map() closing bracket.

What it is now:

<mesh>
-  {colors.map((color, index) => <meshBasicMaterial key={index} attachArray="material" color={color} />}
+  {colors.map((color, index) => <meshBasicMaterial key={index} attach={`material-${index}`} color={color} />}
</mesh>

What it should be:

<mesh>
-  {colors.map((color, index) => <meshBasicMaterial key={index} attachArray="material" color={color} />)}
+  {colors.map((color, index) => <meshBasicMaterial key={index} attach={`material-${index}`} color={color} />)}
</mesh>
@joshuaellis joshuaellis added documentation to do with docs core target agnostic (normally to do with reconciler) good first issue Good for newcomers and removed core target agnostic (normally to do with reconciler) labels Apr 1, 2022
@joshuaellis
Copy link
Member

Please feel free to make a PR to address this.

@Sandi2212
Copy link

Sandi2212 commented Apr 4, 2022 •
edited

has anyone picked this up? If not pls assign this to me

@pmndrs pmndrs deleted a comment from teknikservishg May 11, 2022
@pmndrs pmndrs deleted a comment from teknikservishg May 11, 2022
@pmndrs pmndrs deleted a comment from teknikservishg May 11, 2022
@pmndrs pmndrs deleted a comment from teknikservishg May 11, 2022
@pmndrs pmndrs deleted a comment from teknikservishg May 11, 2022
@pmndrs pmndrs deleted a comment from teknikservishg May 11, 2022
@pmndrs pmndrs deleted a comment from teknikservishg May 11, 2022
@ys7i ys7i mentioned this issue May 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sandi2212 Sandi2212

Labels
documentation to do with docs good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshuaellis @Sandi2212 @JarrodM-M