Skip to content

Commit

Permalink
Fix check_error_codes CI job (#24692)
Browse files Browse the repository at this point in the history 
The diff command was missing a --quiet argument, causing the job not to
fail when unminified messages were found.
  • Loading branch information
@acdlite
acdlite committed Jun 8, 2022
1 parent 060505e commit 42b330c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Expand Up @@ -329,7 +329,7 @@ jobs:
name: Search build artifacts for unminified errors
command: |
yarn extract-errors
git diff || (echo "Found unminified errors. Either update the error codes map or disable error minification for the affected build, if appropriate." && false)
git diff --quiet || (echo "Found unminified errors. Either update the error codes map or disable error minification for the affected build, if appropriate." && false)

This comment has been minimized.

Sign in to view

Copy link
@ahmedosama2022

ahmedosama2022 Aug 29, 2022

ikk
yarn_test:
docker: *docker
Expand Down

1 comment on commit 42b330c

@keepn1221
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.circleci/config.yml

Please sign in to comment.