Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend emojis to match github #128

Open
EstebanDalelR opened this issue Apr 21, 2022 · 6 comments
Open

Extend emojis to match github #128

EstebanDalelR opened this issue Apr 21, 2022 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@EstebanDalelR
Copy link
Member

:godmode: fails 馃槶

@EstebanDalelR
Copy link
Member Author

https://cawolfkreo.github.io/Cease-and-Desist-History-Big-N/
Example repo where it's extensively used @cawolfkreo

@cawolfkreo
Copy link

Small thing, the full link to the repo is this one: https://github.com/cawolfkreo/Cease-and-Desist-History-Big-N

Also, after doing some research there are packages for JS/TypeScript that could give some help implementing this, like this one.

@cawolfkreo
Copy link

I should also say you can fetch the image for the emoji directly from github. I don't know if it's the best way but since you do need an internet connection to fetch github data, it could also work. This means you can grab the name of the emoji between the :s and then put it on the respective url, like so:

imagen

@EstebanDalelR
Copy link
Member Author

@cawolfkreo you seem to be volunteering for this lol
I think it's a regex that finds ":godmode:" and replaces with the image

@EstebanDalelR
Copy link
Member Author

Maybe not all but a few.
Here's the source:https://github.com/rhysd/node-github-emoji/blob/master/src/emoji.json

@EstebanDalelR EstebanDalelR added the enhancement New feature or request label Apr 22, 2022
@EstebanDalelR
Copy link
Member Author

https://docs.github.com/en/rest/emojis#get-emojis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants