Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that default download directory is writable on daemon startup #3270

Open
lyoshenka opened this issue Apr 20, 2021 · 10 comments
Open

Ensure that default download directory is writable on daemon startup #3270

lyoshenka opened this issue Apr 20, 2021 · 10 comments
Labels
area: downloads good first issue help wanted type: improvement Existing (or partially existing) functionality needs to be changed

Comments

@lyoshenka
Copy link
Member

Creating a new issue based on #877

  • Update ensure_directory_exists() to check that the directory is writable by the current process.
  • If it's not, return a useful error
  • Add tests to cover the case when
    • download directory does not exist
    • download dir exists but is not writable
    • dir exists and is writable
    • the path refers to a file not a directory

bonus: also check if disk is full when sdk starts. this check should be outside ensure_directory_exists(). it probably goes somewhere near here
@lyoshenka lyoshenka mentioned this issue Apr 20, 2021
Closed
@lyoshenka lyoshenka added area: downloads good first issue help wanted type: improvement Existing (or partially existing) functionality needs to be changed labels Apr 20, 2021
@snapperVibes
Copy link

"Good first issue" is what I'm looking for! I'll write the code tomorrow.

@snapperVibes snapperVibes mentioned this issue Apr 21, 2021
Closed
@jeffreypicard
Copy link
Collaborator

jeffreypicard commented Apr 23, 2021 •
edited

PR for this #3276
@snapperVibes sorry, didn't mean to try to snipe you, didn't see your comment until after I finished this!

@snapperVibes
Copy link

snapperVibes commented Apr 23, 2021 •
edited

Your code is cleaner anyways.

@Rishabhraghwendra18
Copy link

Hi @snapperVibes is this issue open ?

@snapperVibes
Copy link

snapperVibes commented Jul 7, 2021 •
edited

It's closed

@RyanRussell00
Copy link

@lyoshenka Is this issue open or closed?

@tzarebczan
Copy link
Contributor

This issue is open.

@pseudoscalar pseudoscalar mentioned this issue Sep 12, 2021
Closed
@ghost
Copy link

ghost commented Oct 20, 2021

The pull request #3457, updating the ensure_directory_exists(), is available for a review.

@ghost
Copy link

ghost commented Oct 23, 2021

How impactful is the problem of the absence of the storage capacity fullness check on the start up?
What would be a suitable methodology to verify the full storage capacity scenario?
Would there be a merit in adding a check to see if the storage will potentially become full after a download? How impactful would the programming effort be?

@ghost
Copy link

ghost commented Oct 27, 2021

The ensure_directory_exists() now checks the directory is writable by the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: downloads good first issue help wanted type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Detect non-writable and full data directories pseudoscalar/lbry-sdk
6 participants
@lyoshenka @jeffreypicard @tzarebczan @RyanRussell00 @Rishabhraghwendra18 @snapperVibes